[gst-devel] Re: [gst-cvs] ensonic gst-plugins-base: gst-plugins-base/ gst-plugins-base/gst/adder/ gst-plugins-base/gst/volume/ gst-plugins-base/tests/check/ gst-plugins-base/tests/check/elements/ gst-plugins-base/tests/check/generic/
Thomas Vander Stichele
thomas at apestaart.org
Tue May 30 07:30:05 CEST 2006
Hi Stefan,
two things:
a) you REALLY REALLY REALLY need to learn to separate your commits. You
have a habit of committing huge chunks of stuff together that is not
necessarily related. It made me completely miss the thing you commited
below in b)
b)
> --- states.c 29 Dec 2005 11:49:11 -0000 1.7
> +++ states.c 28 May 2006 19:42:27 -0000 1.8
> @@ -62,6 +62,11 @@
> GST_DEBUG ("testing element %s", name);
> element = gst_element_factory_make (name, name);
> + if (!element) {
> + GST_WARNING ("failed to create element %s", name);
> + continue;
> + }
> if (GST_IS_PIPELINE (element)) {
> GST_DEBUG ("element %s is a pipeline", name);
> }
This is the wrong way to fix the test. If an element can't be made,
this is a BUG. The test should STOP. The reason for the element not
being makeable should be FIXED.
Please consider splitting up future commits ?
Thanks
Thomas
More information about the gstreamer-devel
mailing list