[gst-devel] [gst-cvs] ensonic gst-plugins-base: gst-plugins-base/ gst-plugins-base/gst/adder/ gst-plugins-base/gst/volume/ gst-plugins-base/tests/check/ gst-plugins-base/tests/check/elements/ gst-plugins-base/tests/check/generic/

[Stefan Kost]

hi thomas,

do you really this I do this intentional, to tease you to see if someone
discovers it? Dispite my long work day I try to continue to work on gst.
And Iam concerned abozt quality. I try to write tests & docs. I watch
the buildbot and try to fix it, of course I am not perfect and make
mistakes.

Lets try to keep a friendly athmosphere. I've just went over 300 files
and fixed more broken gobject macros. I am not going to ask everyone in
public why the copied these macos without thinking if there are right or
wrong, or how it can be that new plugins are accespted in -good and
still have such broken macros in there.

I am fine if you e.g. point me to mistakes I made on irc or mlist, but
lowercase letters and a friendly tone will do.

Stefan


Am Dienstag, den 30.05.2006, 16:29 +0200 schrieb Thomas Vander Stichele:
> Hi Stefan,
> 
> two things:
> 
> a) you REALLY REALLY REALLY need to learn to separate your commits.  You
> have a habit of committing huge chunks of stuff together that is not
> necessarily related.  It made me completely miss the thing you commited
> below in b)
> 
> b)
> 
> > --- states.c	29 Dec 2005 11:49:11 -0000	1.7
> > +++ states.c	28 May 2006 19:42:27 -0000	1.8
> > @@ -62,6 +62,11 @@
> >        GST_DEBUG ("testing element %s", name);
> >        element = gst_element_factory_make (name, name);
> > +      if (!element) {
> > +        GST_WARNING ("failed to create element %s", name);
> > +        continue;
> > +      }
> >        if (GST_IS_PIPELINE (element)) {
> >          GST_DEBUG ("element %s is a pipeline", name);
> >        }
> 
> This is the wrong way to fix the test.  If an element can't be made,
> this is a BUG.  The test should STOP.  The reason for the element not
> being makeable should be FIXED.
> 
> Please consider splitting up future commits ?
> 
> Thanks
> Thomas
> 
> 
> 
> 
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel