[gst-devel] [gst-cvs] slomo gst-plugins-base: gst-plugins-base/ gst-plugins-base/gst/volume/ gst-plugins-base/tests/check/elements/

[Sebastian Dröge]

Am Freitag, den 07.09.2007, 17:33 +0200 schrieb Andy Wingo:
> Hi Slomo,
> 
> On Wed 05 Sep 2007 23:20, slomo at kemper.freedesktop.org writes:
> 
> > CVS Root:       /cvs/gstreamer
> > Module:         gst-plugins-base
> > Changes by:     slomo
> > Date:           Wed Sep 05 2007  21:20:27 UTC
> >
> > Log message:
> > * gst/volume/gstvolume.c: (volume_choose_func),
> > (volume_process_double), (volume_process_double_clamp),
> > (volume_process_float_clamp):
> > Correctly clamp float/double samples in the [-1.0,1.0] range to
> > prevent weird effects.
> 
> Is this correct? I would think "probably not". When converting back to
> int, the values should be clamped, but I don't see the need for it when
> overdriving the volume. 1.0f is 0dB, but higher values are possible.

After thinking about it again you're probably right. I'll change that
back to the old behaviour and adjust the unit test for this tomorrow.
Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20070908/c06ee2c3/attachment.pgp>