[gst-devel] [gst-cvs] mnauw gst-plugins-base: gst-plugins-base/ gst-plugins-base/gst-libs/gst/video/

[David Schleef]

On Tue, Jul 15, 2008 at 11:12:13AM +0200, Mark Nauwelaerts wrote:
> > Also, it changes ABI.
> 
> It might change API in that it would now return TRUE for a non-fixed caps.

Bingo.  This behavior is relied upon in other areas of code.

> If not finding that a solution, what would then be an acceptable way to re-use 
> exactly the same code to determine format for a non-fixed width, height etc 
> (which is irrelevant in the format determination) ?  Add some other API function 
> (_full/_non_fixed ?) that internally calls upon the same (slightly re-factored) 
> code.  After all, it's nice code, so let's use it as much as possible :)

You'd need to write a lot of code to do this.  Basically, for each
parameter, write a function that walks the caps structures and checks
that each structure has the same fixed parameter.  It's not as simple
as not checking for fixed caps.

I don't see much usefulness in this.  In GStreamer elements, you're
either extracting information from fixed caps, as in a setcaps()
function, or you're dealing with a potentially complex caps description
that should be handled fully instead of using shortcuts.



dave...