gst_info suggestion

[Tim-Philipp Müller]

On Thu, 2012-10-11 at 17:34 +0800, hcpwll wrote:


>                    #define GST_CAT_DEFAULT my_plugin
>                    #include <gst/info.h>
>                    GST_DEBUG_CATEGORY_STATIC( my_plugin); 
>
>              the compiler complain "error: static declaration of
'my_plugin' follows non-static decalration.

I think the expected usage pattern here is:

  #include <gst/gst.h>
  #define GST_CAT_DEFAULT my_plugin
  GST_DEBUG_CATEGORY_STATIC (my_plugin);


There might still be something to improve in the headers though, not
sure. Feel free to file a bug in bugzilla for it.


>           2, Currently,  The functions of parse debug parameters is in
> the gst.c, for example parse_debug_list function.
>                In my opinion, Should put it in the gst_info.c. In this
> way, the gst_info.h need not to export some global functions
>                for example gst_debug_set_threshould_for_name.

There is a bug to make this function public API and move it into
gstinfo.c, fwiw.

https://bugzilla.gnome.org/show_bug.cgi?id=679152

Cheers
 -Tim