gst-plugins-gl 0.10.3 glshader element bug

[comicfans44]

Hello everyone,
   I'm learning gstreamer gl plugin , and I found there is a bug in 
gstglfiltershader.c , when loading shader file ,it should pass "r"(for fopen)
instead of O_RDONLY (for open) ,this leads a crash when using glshader 
element. and here's a quick fix. (based on gst-plugins-gl-0.10.3)
plus, is there some example shader file 
 or some detail document? glshader may be greate for shader based video process test,
but documents said little about "vars" file format or "preset" file format

--- a/gst/gl/gstglfiltershader.c 2012-05-08 12:43:19.000000000 +0800
+++ b/gst/gl/gstglfiltershader.c 2013-06-20 15:49:52.639081794 +0800
@@ -263,7 +263,7 @@
 
   // read the filter from file
   GST_INFO ("loading file: %s", filename);
-  f = fopen (filename, O_RDONLY);
+  f = fopen (filename, "r");
   if (f == NULL) {
     GST_ERROR ("could not open file: %s", filename);
     return -1;



comicfans44
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20130620/63503017/attachment-0001.html>