gst-plugins-good: rtph264pay: unbreak au aligned byte-stream payloading

[Tim-Philipp Müller]

On Sun, 2014-08-03 at 05:44 -0700, Mark Nauwelaerts wrote:

Hi,

this breaks the elements/rtp-payloading unit test for me:

Running suite(s): rtp_data_test
93%: Checks: 30, Failures: 2, Errors: 0
elements/rtp-payloading.c:360:F:linear:rtp_h264_list_lt_mtu:0: Failure
'chain_list_bytes_received != bytes_sent * LOOP_COUNT' occured
elements/rtp-payloading.c:360:F:linear:rtp_h264_list_gt_mtu:0: Failure
'chain_list_bytes_received != bytes_sent * LOOP_COUNT' occured

Cheers
 -Tim

> Module: gst-plugins-good
> Branch: master
> Commit: d5d28055c1e816e90e8c2d1151816b0c3e760ff3
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=d5d28055c1e816e90e8c2d1151816b0c3e760ff3
> 
> Author: 
> Date:   Sun Aug  3 12:33:32 2014 +0200
> 
> rtph264pay: unbreak au aligned byte-stream payloading
> 
> ---
> 
>  gst/rtp/gstrtph264pay.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gst/rtp/gstrtph264pay.c b/gst/rtp/gstrtph264pay.c
> index d3e319b..c451c71 100644
> --- a/gst/rtp/gstrtph264pay.c
> +++ b/gst/rtp/gstrtph264pay.c
> @@ -1141,7 +1141,9 @@ gst_rtp_h264_pay_handle_buffer (GstRTPBasePayload * basepayload,
>         */
>        next = next_start_code (data, size);
>  
> -      if (next == size && buffer != NULL) {
> +      /* nal or au aligned input needs no delaying until next time */
> +      if (next == size && buffer != NULL &&
> +          rtph264pay->alignment == GST_H264_ALIGNMENT_UNKNOWN) {
>          /* Didn't find the start of next NAL and it's not EOS,
>           * handle it next time */
>          break;
> 
> _______________________________________________
> gstreamer-commits mailing list
> gstreamer-commits at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits