gst-plugins-bad: configure: check for good enough dvb kernel headers

[Edward Hervey]

Hi,

  This check is somewhat wrong. It should be using the DVB_API_VERSION
defines to check if we have a recent enough version and not a specific
symbol.

http://lxr.free-electrons.com/source/include/uapi/linux/dvb/version.h#L26

   Edward

On Thu, 2014-01-09 at 07:58 -0800, Stefan Kost wrote:
> Module: gst-plugins-bad
> Branch: master
> Commit: 8b1bd860008a8f7668dfbb4b6750317c01b55d48
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=8b1bd860008a8f7668dfbb4b6750317c01b55d48
> 
> Author: Stefan Sauer <ensonic at users.sf.net>
> Date:   Thu Jan  9 16:38:13 2014 +0100
> 
> configure: check for good enough dvb kernel headers
> 
> Recent changes are using new dvb api. Don't built the plugin, if we can't.
> Fixes #721869
> 
> ---
> 
>  configure.ac |   15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4646262..6abfab0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2040,7 +2040,7 @@ AG_GST_CHECK_FEATURE(XVID, [xvid plugins], xvid, [
>      AC_CHECK_LIB(xvidcore, xvid_encore, [
>        AC_CHECK_LIB(xvidcore, xvid_decore, [
>          AC_CHECK_LIB(xvidcore, xvid_global, [
> -          AC_MSG_CHECKING([for uptodate XviD API version])
> +          AC_MSG_CHECKING([for up-to-date XviD API version])
>            AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <xvid.h>]], [[
>                #if XVID_API_MAJOR(XVID_API) != 4
>                #error "Incompatible XviD API version"
> @@ -2064,7 +2064,18 @@ dnl *** dvb ***
>  translit(dnm, m, l) AM_CONDITIONAL(USE_DVB, true)
>  AG_GST_CHECK_FEATURE(DVB, [DVB Source], dvb, [
>    AC_MSG_CHECKING([Checking for up to date dvb installation])
> -  AC_CHECK_HEADER(linux/dvb/frontend.h, [HAVE_DVB="yes"], [HAVE_DVB="no"])
> +  AC_CHECK_HEADER(linux/dvb/frontend.h, [
> +    AC_MSG_CHECKING([for up-to-date dvb API])
> +    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <linux/dvb/frontend.h>]], [[
> +        #ifndef SYS_DVBC_ANNEX_AC
> +        #error "Incompatible dvb API"
> +        #endif
> +    ]])], [ AC_MSG_RESULT(yes)
> +      HAVE_DVB="yes"
> +    ], [ AC_MSG_RESULT(no)
> +      HAVE_DVB="no"
> +    ])
> +  ], [HAVE_DVB="no"])
>  ])
>  
>  dnl *** wininet ***
> 
> _______________________________________________
> gstreamer-commits mailing list
> gstreamer-commits at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20140110/af4037c8/attachment.pgp>