gst-plugins-bad: glupload/download/convert: provide transform_caps functions

Matthew Waters ystreet00 at gmail.com
Wed Feb 4 16:10:48 PST 2015


On 05/02/15 03:45, Sebastian Dröge wrote:
> On Mo, 2015-02-02 at 19:36 -0800, Matthew Waters wrote:
>> Module: gst-plugins-bad
>> Branch: master
>> Commit: c06715bde6b261d3f93381a0bdb57cab0e35c647
>> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=c06715bde6b261d3f93381a0bdb57cab0e35c647
>>
>> Author: Matthew Waters <matthew at centricular.com>
>> Date:   Tue Feb  3 00:11:06 2015 +1100
>>
>> glupload/download/convert: provide transform_caps functions
>>
>> Allows finer grain decisions about formats and features at each
>> stage of the pipeline.
>> Also provide propose_allocation for glupload besed on the supported
>> methods.
> This commit breaks support for anything but RGBA in glimagesink,
> gltestsrc and probably also the others :)
>
> I think the transform function in colorconvert is wrong, as it only
> intersects while it should probably remove the format info first? That
> fixes it, but I'm not sure if that is correct. There's also that
> function in glimagesink's getcaps to remove the format, but it only does
> that for sysmem caps, so it is a complete no-op currently. So a few ways
> of fixing this, but I don't know how it is supposed to work.

The colorconvert transform function was wrong :).  The eventual idea is
for https://bugzilla.gnome.org/show_bug.cgi?id=743974 to be implemented
and each element does its own transform_caps function.

commit 8c91da6f75a849aa13a14fda0fd23479d4a5c0f6
Author: Matthew Waters <matthew at centricular.com>
Date:   Thu Feb 5 11:04:05 2015 +1100

    glcolorconvert: don't intersect with the input caps
   
    that limits our formats to whatever is in the input caps

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20150205/cf584bc3/attachment.sig>


More information about the gstreamer-devel mailing list