gst-plugins-good: videocrop mark crop properties as mutable in playing state

[Tim-Philipp Müller]

On Mon, 2016-05-23 at 20:24 -0400, Nicolas Dufresne wrote:

> > 
> > videocrop mark crop properties as mutable in playing state
> > 
> Last time I tested, changing those in playing state lead to a crash
> or spurious negotiation error. I had to use a probe in front to
> safely be able to change this.

It will depend on the pipeline I think? Were the crashes in videocrop?

./videocrop2-test changes these properties at runtime and that seems to
work fine for me. Not that I'd be surprised if there are bugs given the
async nature of this all.

I see there's https://bugzilla.gnome.org/show_bug.cgi?id=761163 of
course, but it's a bit all over the place really - as far as I can tell
vieocrop already tries to queue the changes, but perhaps not in all
places where it should? 

Are you suggesting we don't mark them as mutable because it's not
necessarily 100% bulletproof in all scenarios even though it mostly
works fine? I don't really mind, I was just under the impression that
it should work in principle and remembered the test programs we had
worked fine, and someone asked about it on irc :)

Cheers
 -Tim