qtgl plugins: GLsync missing from gstgl_gles2compat.h?

[Matthew Waters]

Can you submit a MR to
https://gitlab.freedesktop.org/gstreamer/gst-plugins-good please.

On 25/11/19 8:58 pm, Milian Wolff wrote:
> On Friday, November 22, 2019 5:16:27 AM CET Matthew Waters wrote:
>> Hi,
>>
>> This is a common build error for building the qmlgl plugins and while
>> the hack in ext/qt/gstqtgl.h is meant to help, obviously it does not for
>> you.  If you can find a set up of #include's and defined that works on
>> both the RPi and on a normal desktop linux without performing rpi
>> specific hacks, then I'd be happy to review that patch.
> The fix seems to be simple:
>
> You are missing an explicit include of 
>
> #include <QtGui/qopengl.h>
>
> in gstqtgl.h
>
> Apparently on the other platforms, this is pulled in from elsewhere 
> automatically. But on my configuration at least, it isn't, and thus 
> qopengles2ext.h is never included and thereby GLsync never gets defined.
>
> Could you include that fix please, or do I need to submit a patch for this?
>
> Cheers



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20191125/fabcf2cb/attachment.sig>