AW: [External] Re: glupload + vaapi + appsink = texture leak?

[Matthew Waters]

The difference between the two scenarios is the use of a
GstGLBufferPool.  GstGLBufferPool (GstBufferPool actually) will
implement the behaviour you're expecting to see by reusing freed
GstBuffers (and therefore GstMemory (GstGLMemory) and therefore
textures) and is used automatically in the gltestsrc or qmlglsink
cases.  GstGLBufferPool may not used be in a pipeline with a glupload
element directly into appsink.

There is no automatic reuse of texture ids within OpenGL itself.

Increasing texture ids is not indicative of a leak of textures.

Cheers
-Matt

On 19/2/20 6:36 pm, Timtchenko, Michael wrote:
> Well... sent to fast and forgot to add mailing list ... mea culpa :-/
>
> Anyway.. I should add relevant information any.
>
> When appsink is replaced by gstqtsink the returned texture ids stay in the same range.
>
> BR Michael
>
> -----Ursprüngliche Nachricht-----
> Von: Timtchenko, Michael
> Gesendet: Mittwoch, 19. Februar 2020 08:29
> An: 'Matthew Waters' <ystreet00 at gmail.com>
> Betreff: AW: [External] Re: glupload + vaapi + appsink = texture leak?
>
> Hi Matt,
>
> thx 4 reply!
>
> Am i right, that the texture should be destroyed when the corresponding frame is unmapped and no references are hold to it?
>
> If this is true and the freed texture id should be used again, then sth wents wrong here. (or not?)
>
> Is it really valid, when texture ids rise within some seconds to a value up to 3000 or sth when it's not bound? I've a isolated environment where I'm getting the callback from appsink, pulling the texture and unmapping it again.
>
> What seems odd to me is that, the gltestsrc is reusing the textureids in a small range...
>
> P.S. Running gstreamer 1.16.2
>
> BR Michael
>
>
> -----Ursprüngliche Nachricht-----
> Von: Matthew Waters [mailto:ystreet00 at gmail.com]
> Gesendet: Mittwoch, 19. Februar 2020 08:17
> An: Discussion of the development of and with GStreamer <gstreamer-devel at lists.freedesktop.org>; Timtchenko, Michael <Michael.Timtchenko at agcocorp.com>
> Betreff: [External] Re: glupload + vaapi + appsink = texture leak?
>
> A steadily increasing texture id is not indicative of a texture leak. Each texture created by glupload from a dmabuf source can be a completely new one and can be destroyed when not needed anymore.
>
> Cheers
> -Matt
>
> On 19/2/20 6:01 pm, Timtchenko, Michael wrote:
>> Hi all,
>>
>> i'm running the pipeline:
>>
>> "udpsrc caps="application/x-rtp, media=(string)video,
>> clock-rate=(int)90000, encoding-name=(string)H264, payload=(int)96" !
>> rtph264depay ! vaapih264dec ! vaapipostproc !
>> video/x-raw(memory:DMABuf) ! glupload ! appsink
>>
>> When i'm retrieving the uploaded textures within appsink, I get steadily increased texture ids. It seems like, there is something leaking within the pipeline.
>>
>> When I'm running "gltestsrc ! glupload ! appsink" the texture increases and decreases within a small range.
>>
>> Are there known issues about this?
>>
>> BR Michael
>>
>>
>> Bitte beachten / Please note!
>>
>> **********************************************************************
>> *********
>>
>> AGCO GmbH
>> Sitz der AGCO GmbH: Johann-Georg-Fendt-Str.4, 87616 Marktoberdorf,
>> Germany Registergericht Amtsgericht Kempten HRB 10327
>> Geschäftsführer: Christoph Groeblinghoff, Ingrid Bussjaeger-Martin,
>> Dr. Heribert Reiter, Ekkehart Glaeser Vorsitzender des Aufsichtsrates:
>> Torsten Dehner
>>
>> **********************************************************************
>> *********
>>
>> Diese E-Mail ist nur für den Empfänger bestimmt, an den es gerichtet
>> ist und kann vertrauliches bzw. unter das Berufsgeheimnis fallendes
>> Material enthalten. Jegliche darin enthaltene Ansicht oder
>> Meinungsäußerung ist die des Autors und stellt nicht notwendigerweise
>> die Ansicht oder Meinung von AGCO dar. Sind Sie nicht der Empfänger,
>> so haben Sie diese E-Mail irrtümlich erhalten und jegliche Verwendung,
>> Veröffentlichung, Weiterleitung, Abschrift oder jeglicher Druck dieser
>> E-Mail ist strengstens untersagt. Weder AGCO noch der Absender übernehmen die Haftung für Viren; es obliegt Ihrer Verantwortung, die E-Mail und deren angehängte Dateien (sofern vorhanden) auf Viren zu überprüfen.
>>
>> **********************************************************************
>> *********
>>
>> This email is intended solely for the use of the individual to whom it
>> is addressed and may contain confidential and/or privileged material.
>> Any views or opinions presented are solely those of the author and do
>> not necessarily represent those of AGCO. If you are not the intended
>> recipient, be advised that you have received this email in error and
>> that any use, dissemination, forwarding, printing or copying of this
>> email is strictly prohibited. Neither AGCO nor the sender accepts any
>> responsibility for viruses and it is your responsibility to scan and
>> virus check the email and its
>> attachment(s) (if any).
>>
>> **********************************************************************
>> ********* _______________________________________________
>> gstreamer-devel mailing list
>> gstreamer-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/gstreamer-devel
>
>
>
> This email is intended solely for the use of the individual to whom it is addressed and may contain confidential and/or privileged material. Any views or opinions presented are solely those of the author and do not necessarily represent those of AGCO. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing or copying of this email is strictly prohibited. Neither AGCO nor the sender accepts any responsibility for viruses and it is your responsibility to scan and virus check the e-mail and its attachment(s) (if any).



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/gstreamer-devel/attachments/20200219/15792b8a/attachment-0001.sig>