[patch] Move negative checks to util.c, from acpi.c (resend)
David Zeuthen
davidz at redhat.com
Fri Aug 19 11:19:05 PDT 2005
On Fri, 2005-08-19 at 19:09 +0100, Richard Hughes wrote:
> On Fri, 2005-08-19 at 13:42 -0400, David Zeuthen wrote:
> > On Fri, 2005-08-19 at 15:50 +0100, Richard Hughes wrote:
> > > Agreed, what about the attached? Good to commit?
> >
> > I don't see us explicitly removing the properties if the helper util
> > function returns -1.. we probably should. Also need a patch for the spec
> > to tag the properties as optional..
>
> You mean something like this?
+ <entry><literal>battery.charge_level.percentage</literal> (int)</entry>
Here we also need change in the spec for battery.remaining_time.
The patch looks good to me from looking at it but make sure you've
tested all the corner cases. I haven't tested it myself yet...
We also need an entry in ChangeLog for doc/spec/hal-spec.xml.in changes.
Thanks,
David
More information about the hal
mailing list