[patch] Move negative checks to util.c, from acpi.c (resend)

[Richard Hughes]

On Fri, 2005-08-19 at 14:19 -0400, David Zeuthen wrote:
> On Fri, 2005-08-19 at 19:09 +0100, Richard Hughes wrote:
> > On Fri, 2005-08-19 at 13:42 -0400, David Zeuthen wrote:
> > > On Fri, 2005-08-19 at 15:50 +0100, Richard Hughes wrote:
> > > > Agreed, what about the attached? Good to commit?
> > > 
> > > I don't see us explicitly removing the properties if the helper util
> > > function returns -1.. we probably should. Also need a patch for the spec
> > > to tag the properties as optional..
> > 
> > You mean something like this?
> 
> +              <entry><literal>battery.charge_level.percentage</literal> (int)</entry>
> 
> Here we also need change in the spec for battery.remaining_time. 
> 
> The patch looks good to me from looking at it but make sure you've
> tested all the corner cases. I haven't tested it myself yet...

I'm sure this is the best way to do this. I'll give it a hammering this
week, but I would like to get this in soon so that I can work on other
stuff (hid-ups needs some love).

> We also need an entry in ChangeLog for doc/spec/hal-spec.xml.in changes.

Done. Newest version attached.

Richard.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-diff-2005-08-19-19-34-51.patch
Type: text/x-patch
Size: 11964 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20050819/75a3b53b/hal-diff-2005-08-19-19-34-51.bin