ACPI "special" button device, and Toshiba specific bits

[Richard Hughes]

On Thu, 2005-12-01 at 21:18 +0100, Timo Hoenig wrote:
> On Thu, 2005-12-01 at 17:24 +0000, Richard Hughes wrote:
> 
> > >  3. Finally, why does the mapping from e.g. "Satellite Pro A10" to what
> > >     keycodes does what have to be configurable in an .fdi file? Why
> > >     don't you just hardcode that in the toshiba addon? It's not like
> > >     it's likely to change, right?
> > 
> > Ohh yes it is :-) Some Toshibas have button mappings different to each
> > other, and some have buttons that don't exist. Plus keeping it in the
> > FDI lets us re-map buttons (such as F1 = Lock) without enforcing the
> > policy in the addon.
> 
> This is wrong.
> 
> The mapping for (hotkey symbol) -> (HCI value) is the same for all
> Toshiba laptops.
> 
> Re-mapping keys is not necessary.  The amount of hotkeys may differ; but
> not the meaning of the hotkeys' symbols.

Oh, you are most probably correct, I'm only basing my opinion on one
(sketchy) report. I still think this should stay in a FDI file so we can
trivially add new buttons (as toshiba add them ;-)), but I'll take out
the Satellite Pro specific bit.

Richard.