[patch] addon-hid-ups.c : battery.present is mandatory for HAL spec

David Zeuthen david at fubar.dk
Sun May 8 20:52:40 PDT 2005


On Sun, 2005-05-08 at 19:32 +0100, Richard Hughes wrote:
> According to the HAL spec, battery.present is compulsory for devices
> that have capability battery.
> 
> Whilst programming the tooltip logic for Power Manager, I noticed that
> battery.present is never set for my UPS. 

I'm aware of this issue

 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=151766

Note that with an old enough kernel this (and other values) are set
correctly

 http://people.redhat.com/davidz/hal-hid-ups.png

> It makes no sense to have a UPS
> without a battery (you can't hot-change the batteries...) 

Actually it does though addon-hid-ups doesn't support it just yet.
Should be easy though, patches are welcome :-).

> so this
> parameter should be hard-coded.
> 
> Patch attached.

OK, I suppose we can set it so it works with kernels that are borked
too :-). Applied.

David


_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal



More information about the Hal mailing list