[PATCH] lshal - The next generation

Pierre Ossman drzeus-list at drzeus.cx
Wed Nov 2 04:32:32 PST 2005


Richard Hughes wrote:
> On Wed, 2005-11-02 at 11:41 +0100, Pierre Ossman wrote:
>   
>> -       dump_devices ();
>> +       if (show_device)
>> +               dump_device (show_device);
>> +       else
>> +               dump_devices ();
>>     
>
> Shouldn't this be:
>
>       if (show_device)
>               dump_device (show_device);
>       else if (!do_monitor)
>               dump_devices ();
>
> Else you list the device tree when you monitor.
>
>   

That would be a seperate patch since I wanted to keep the old behaviour 
in this go. Feel free to add it though. :)

Rgds
Pierre



More information about the hal mailing list