3of3 acpi.c Adding initial quirk BIOS handling

Richard Hughes hughsient at gmail.com
Fri Oct 14 13:29:17 PDT 2005

On Fri, 2005-10-14 at 22:05 +0200, Danny Kukawka wrote:
> On Friday 14 October 2005 21:07, Richard Hughes wrote:
> > Are the cleanup patches 1-3 and 2-3 okay to merge (now?) in your
> > opinion? I don't want my local tree to become too different.
> I could first today take a deeper look at the patch. I think 1-3 is o.k. For 
> the second my little note:
> > * hald/linux2/acpi.h: Move static structures and enums from acpi.c
> Not sure if this is needed. Do you plan to reuse this structures and enums 
> somewhere in HAL and outside of acpi.c ? If not, this change is IMO not 
> necessary. 
> If you apply this, you change this _file static_ structures and enums to 
> _global static_ (means static in all files including acpi.h). Is this really 
> needed?

No I was just cleaning up the file. I see your point about the header.

Assuming I drop the header moveabout, you happy with 2of3 too?


More information about the hal mailing list