[patch] complete get and set lcd patch

Richard Hughes hughsient at gmail.com
Sun Sep 4 02:03:47 EST 2005


On Fri, 2005-09-02 at 16:25 -0400, David Zeuthen wrote:
> On Thu, 2005-09-01 at 21:42 +0100, Richard Hughes wrote:
> > Yes, sorry. Late night hacking can have this effect.
> > 
> > Newest patch attached. Tell me what you think.
> 
> Looks good to me to commit. Please make sure that the scripts
> 
>  tools/hal-system-lcd-get-brightness
>  tools/hal-system-lcd-set-brightness
> 
> are marked as executable (chmod a+x) before adding and committing them
> to CVS. 

Done so.

> Also, if you can check that everything works as expected with a
> fresh checkout [1] it would be great.

Also done, I ended up making a RPM for a FC4'ish system and testing on
that. It worked fine. With G-P-M CVS, it'll work out of the box. :-)

> Thanks a lot for this, it looks good.

Thanks David,

Richard.

> Cheers,
> David
> 
> [1] : On Fedora Rawhide do 
> 
>  ./autogen.sh --prefix=/usr --sysconfdir=/etc --localstatedir=/var
> --disable-docbook-docs --enable-fstab-sync --with-os-type=redhat
> --enable-pcmcia-support --with-stab-file=/var/lib/pcmcia/stab
> 
> then 'make install' and 'service restart haldaemon' once everything is
> built.
> 
> 



More information about the hal mailing list