common code patch for Solaris

David Zeuthen david at fubar.dk
Wed Aug 2 11:23:17 PDT 2006


On Mon, 2006-07-31 at 18:12 -0700, Artem Kachitchkine wrote:
> Please review the patch to get the latest HAL tree work on Solaris. Summary of 
> change:
> 
> 	* configure.in: don't PKG_CHECK volume_id on Solaris
> 	and check for asprintf()
> 	* hald/property.c: C99 compilers do not support anonymous unions
> 	* hald/util.h: redefine gcc macros if not using gcc
> 	* libhal/libhal.c: C99 compilers do not support anonymous unions
> 	* tools/hal-device: C99 compilers do not support anonymous unions,
> 	handle no-asprintf() case, use "a ? a : b" instead of "a ?: b"
> 	* tools/hal-storage-mount.c
> 	  tools/hal-storage-shared.c
> 	  tools/hal-system-power-pmu.c: added Solaris ifdefs

Looks good to me. Thanks. 

Btw, do you have plans to add the Solaris back-end to the git master
repo and if yes when do you expect this to happen? It might be useful
sooner than later because I think we want to start looking at optimizing
some of the HAL internals.

Cheers,
David




More information about the hal mailing list