tray close

[David Zeuthen]

On Mon, 2006-08-14 at 15:31 -0700, Artem Kachitchkine wrote:
> >> - add an optional argument to Eject() method, and hald-storage-eject will append 
> >> -t to the command line;
> >> - or introduce a new method
> > 
> > Or we could use the options parameter (an array of strings) that Eject
> > expects. We can just call the option "trayclose". How about that?
> 
> Well that's what I meant by adding an optional argument to Eject(). It's easier 
> to implement than a new method, though the latter seems cleaner semantically: 
> closing tray is almost opposite to ejecting. Using the analogy, 'gnome-mount -u' 
> equals 'gnome-umount', but we still chose to have separate methods for mount and 
> unmount.

Yea.. I suppose adding a new method might make sense too but remember
that while Eject() applies to more than just optical discs, in fact all
volumes including iPod's, CloseDoor() would apply to the drive. 

So if you want to add a new method, it needs to be on a new interface on
the device object with capability 'storage'. We should probably call it
org.freedesktop.Hal.Device.Storage. Maybe also include Eject() on that
interface too, just for symmetry. Perhaps we want to remove Eject() from
the org.freedesktop.Hal.Device.Volume interface or at least deprecate
it.

What do you think?

    David