[PATCH] Add keyboard event addon

[Sjoerd Simons]

On Sat, Feb 04, 2006 at 12:50:36PM +0000, Richard Hughes wrote:
> On Sat, 2006-02-04 at 11:58 +0000, Matthew Garrett wrote:
> > Richard: this lets brightness button events be sent to g-p-m. On some 
> > machines, hitting the brightness button generates an event and
> > changes 
> > the brightness. On other machines, hitting the brightness button only 
> > generates an event. This is, in general, consistent within a 
> > manufacturer. It would be nice if g-p-m could somehow deal with this
> > and 
> > display the brightness, with it also doing the job of changing the 
> > brightness where necessary (Sonys are the main case where this is a 
> > problem)
> 
> Is this h/w fixed (as in linked with PCB traces), or just set by the
> kernel module?
> 
> If it's truely h/w, I would rather merge an fdi file. I think the vendor
> information should remain outside of g-p-m, so other programs can use
> the info.
> 
> What about laptop_panel.software_brightness_required with false for
> Sony, and true for Toshiba, for example.
> 
> I think this more complex than per-vendor, as DavidZ's powerbook has h/w
> support, but my iBook can do this in software only -- not a problem with
> fdi files.

Not really. Davidz powerbook probably has an ADB keyboard. The adb driver in
the kernel does both set brightness via the pmu (in very little steps) and 
send a key event. 

Iirc you just got your iBook. Recent powerbooks have changed to internal USB 
keyboard, for iBooks it's probably the same. The kernel usb keyboard driver
obviously doesn't change the brightness, so that's the difference your seeing.

  Sjoerd
-- 
If A = B and B = C, then A = C, except where void or prohibited by law.
		-- Roy Santoro