abstracting out shared stuff

David Zeuthen david at fubar.dk
Tue Jun 6 06:56:25 PDT 2006


On Tue, 2006-06-06 at 14:00 +0100, Richard Hughes wrote:
> The droppriv and debug stuff I've abstracted out into separate files,
> removing the bodge of including probing/shared.h into each file that
> needs this stuff.
> 
> Please review.

The hald_debug.[ch] and hald_droppriv.[ch] files should go in a separate
folder hald/hald-utils I think. It's also slight wrong that the main
hald daemon uses it as the logging infrastructure is different. So
suggest to just keep the code for hald as it.

Also this header is wrong

> --- /dev/null   2006-06-06 10:44:07.543993000 +0100
> +++ hald_droppriv.c     2006-06-04 22:16:05.000000000 +0100
> @@ -0,0 +1,79 @@
> +/***************************************************************************
> + * CVSID: $Id: hald_debug.c,v 1.10 2006/05/17 20:12:17 rhughes Exp $
> + *
> + * hald_debug.c - HAL debugging utilities (i.e. dbg)
> 

Apart from that it looks good so please commit it with these changes.

    David




More information about the hal mailing list