[PATCH] sanitize instead of rejecting mountpoints with funny characters

David Zeuthen david at fubar.dk
Wed Mar 1 18:45:01 PST 2006

On Mon, 2006-02-27 at 16:43 +0100, Ludwig Nussel wrote:
> Defining the whitelist is good but as you said it might change. 

With the C code I'm about to commit we only filter out '/'.

> So I'd still
> vote for having the backend substitute invalid characters rather than rejecting
> to mount. The requested mountpoint gets modified anyways if it already exists
> so frontends already have to query the actual mount point after the mount call.

I'm going to change this to throw


if, and only if, the mount point is already occupied and the frontend
explicitly requested this mount point. E.g. if a frontend passes "" then
this exception will never be thrown. Then the frontend can try again
with -1, -2 and so forth. Yes, this is going to change ABI in 0.5.8 a
little bit, but I basically think it's worth it...


More information about the hal mailing list