[PATCH] do not stat autofs mounts(was Re: hall and autofs)

Ian Kent ikent at redhat.com
Fri May 19 19:53:01 PDT 2006


On Fri, 2006-05-19 at 19:52 +0200, Danny Kukawka wrote:
> On Friday 19 May 2006 19:13, David Zeuthen wrote:
> > On Thu, 2006-05-18 at 11:51 +0200, Danny Kukawka wrote:
> > > On Thursday 18 May 2006 00:55, John (J5) Palmieri wrote:
> > > > Thanks for the eyes.  I also noticed I used sizeof instead of strlen in
> > > > strncmp.  Patch take 3.
> > >
> > > There is a (maybe a minor, maybe more) problem with this patch: You don't
> > > know now the mount state of your internal device/partition/volume, if it
> > > is mounted via autofs. I'm not sure if we maybe get problems with the
> > > mount/unmount/eject helper here if we don't know the correct state.
> >
> > Not exactly sure what you're saying here?
> 
> If you ignore all autofs mounted devices (while detect the mount state), you 
> can't detect the mount state of internal hd, fd, cd/dvd-drives, usbstick ... 
> what ever, if they are mounted with autofs.
> 
> HAL never know the state of this devices (hal set they IMO false for 
> is_mounted). This results in two possible problems: wrong mount state 
> provided in HAL and confused mount helper (maybe multiple mounting, maybe 
> some other problems).

If the user chooses to have these devices managed by autofs instead of
HAL perhaps HAL doesn't need to report status.

Ian




More information about the hal mailing list