addon-input starts twice for input devices with key and switch bit set

[Robert Gerlach]

On Tuesday 10 April 2007 10:17:56 Danny Kukawka wrote:
> On Dienstag, 10. April 2007, Robert Gerlach wrote:
> > On Monday 09 April 2007 22:23:10 Danny Kukawka wrote:
> > > What kind of Tablet PC? Which model? What events do you get? Please
> > > provide lshal output.
> >
> > Sorry, "the tablet notebook" should be "my tablet notebook", it's a
> > Fujitsu Siemens LifeBook T4010D. There is a special device (acpi id:
> > FUJ02BF) for the tablet buttons and the display rotation switch. My
> > drivers registered an input device and sends events from this special
> > device to the input subsystem (7 keys and one switch).
> >
> > http://www.khnz.de/fsc_btns/lshal.txt (Device 2 and 3)
> >
> > > Which driver? Kernel module?
> >
> > There is no official kernel support for the tablet stuff, my current
> > devel version is there:
> >
> > http://www.khnz.de/fsc_btns/
>
> Okay, I take a look at this. I have here a T3010 somewhere on my desk and
> may it work also with this machine.

Don't known. Haven't found anything about this device on the net (engeniered 
by playing ;) ). Hope it works for the hole T-Series.

> > Another question, it seems that it's impossible for hal to handle two or
> > more switch events (button with state) from one input device (but it's
> > possible in the kernel). If it right?
>
> What do you mean exactly?

input_test_switch in hald/linux/device.c and probe_input.c looks for one 
switch bit (if ... else  if ...) and set the button properies (button.type, 
button.has_state, button.state.value). But its possible to register multiple 
switches to one input device (for example tablet_mode and headphone_insert). 
It can't handled by hal, or miss I something?
I think it's better to use button.<name>.has_state and button.<name>.value (or 
so) and change button.type to a list.

Robert