pm-suspend: should use quirks by default

Michael Biebl mbiebl at gmail.com
Wed Dec 5 17:21:49 PST 2007


2007/12/5, Till Maas <opensource at till.name>:
> On Mi Dezember 5 2007, Michael Biebl wrote:
> > 2007/12/5, Michael Biebl <mbiebl at gmail.com>:
>
> > > I support this feature request. It should safely fallback to not use
> > > hal though, so pm-utils still works when hal is not installed.
> >
> > I guess it could actually work, if hal simply installed a pm-utils
> > hook which runs first (eg 01hal) and pulls the information from hal
> > and sets the global  QUIRKS variables.
> >
> > This would address the fallback issue I mentioned nicely.
>
>
> My patch is available here:
> http://lists.freedesktop.org/archives/pm-utils/2007-August/000623.html
>
> It uses /usr/bin/hal-get-property and in case the binary is not available,
> nothign should be changed in the beheaviour of pm-utils. It does not make
> using quirks default, but adds an option to use the hal quirks (and to show
> which quirks will be used).
>

This patch looks fine. The only thing missing imho is, that it should
either not offer the --hal-quirks option, when hal is not installed or
display a warning (and probably exit) when the hal-get-property call
has failed.

Cheers,
Michael

P.S: yeah, we should probably move this discussion to pm-utils now.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?


More information about the hal mailing list