Brightness control with the DELL addon

Richard Hughes hughsient at gmail.com
Mon Feb 5 17:06:08 PST 2007


On Mon, 2007-02-05 at 19:17 -0500, David Zeuthen wrote:
> On Mon, 2007-02-05 at 00:40 +0000, Richard Hughes wrote:
> > I think the DELL addon gets the return values incorrect, they should be
> > unsigned ints like the other SetBrightness and GetBrightness methods.
> > 
> > Please review the attached patch.
> 
> No, I'm pretty sure these are signed integers. What makes you think they
> are unsigned? See also 10-laptop-panel-mgmt-policy.fdi.

OOps. My mistake. I see the:

<arg name="return_code" direction="out" type="i"/>

...is quite clearly signed. Sorry for the noise.

Richard.




More information about the hal mailing list