[PATCH] fix build of hald-addon-macbookpro-backlight

[Doug Goldstein]

David Zeuthen wrote:
> 
> Hi, yea, we discussed this one on IRC.
> 
> Danny Kukawka wrote:
>> Ping!
> 
> Sorry for missing this, too much mail the last few months!
> 
>>
>> On Sunday 15 October 2006 17:35, Danny Kukawka wrote:
>>> Hi,
>>>
>>> this little patch adds -lz to CFLAGs of
>>> hald-addon-macbookpro-backlight to
>>> get the addon build clean against newer versions of libpci (pciutils).
>>>
>>> Danny
>>>
>>>  Makefile.am |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Uh, so, at least on Fedora I'm not sure that is needed. And isn't there
> a better fix for this? E.g. somehow to automatically pick up such a
> dependency of a static library?
> 
>      David
> 

No. pciutils 2.2.4 is by default compiled with zlib support. There's no
libpci-config or anything like that.

The only real fix for this is to change AC_CHECK_LIB to when it fails
without -lz, that it tries with -lz and adds that to @PCI_LIBS@

-- 
Doug Goldstein <cardoe at gentoo.org>
http://dev.gentoo.org/~cardoe/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20070214/b0cac65f/signature.pgp