[PATCH] fix gtk-doc code documentation

Danny Kukawka danny.kukawka at web.de
Tue Feb 20 08:12:07 PST 2007


On Thursday 15 February 2007 20:54, David Zeuthen wrote:
> On Tue, 2007-02-13 at 22:45 +0100, Danny Kukawka wrote:
[...]
> > -static enum
> > +static
> >  rule_type get_rule_type (const char *str)
>
> I guess we should return 'int' here (and other places) - omitting the
> return type for a C function seems wrong. 

Do you mean change from:

     static rule_type get_rule_type (const char *str) {...}

to ?:

     static int get_rule_type (const char *str) {...}

I don't see why we shouldn't use rule_type as return value atm. It's a type 
like int or enum. What make the difference? Both works for me and IMO with 
rule_type its more clear what the function returns.

Danny


More information about the hal mailing list