[PATCH] fix gtk-doc code documentation

David Zeuthen david at fubar.dk
Thu Feb 15 11:54:13 PST 2007


On Tue, 2007-02-13 at 22:45 +0100, Danny Kukawka wrote:
> Hi,
> 
> this patch fix the gtk-doc code documentation (why ever we switched from 
> docbook to gtk-doc - IMO docbook was more tolerant and better to use and the 
> change was not the best idea).

Great, thanks for fixing this up. I think we only generate API docs for
libhal and libhal-storage at this point btw. Whether it's useful for the
internals, at this point, is another question. It's always good to fix
up docs though.

> -static enum
> +static 
>  rule_type get_rule_type (const char *str)

I guess we should return 'int' here (and other places) - omitting the
return type for a C function seems wrong. Apart from that it looked good
after giving it a cursory look through a few times. Thanks.

      David




More information about the hal mailing list