[PATCH] add new fdi match attribute contains_not for strlist

Danny Kukawka danny.kukawka at web.de
Wed Feb 28 10:41:33 PST 2007


On Mittwoch, 28. Februar 2007, David Zeuthen wrote:
> On Sat, 2007-02-24 at 18:56 +0100, Danny Kukawka wrote:
> > Hi,
> >
> > This patch adds a new attribute for FDI file match tag for string lists
> > (only). The new attribute named contains_not and allow you to match if a
> > given string is not contained in the string list as in such cases for
> > example:
> >
> >  <match key="info.callouts" contains_not="foobar">
> >   <append key="info.callouts" type="strlist">foobar</append>
> >  </match>
> >
> > This allow you to add e.g. callouts to the list without to double
> > entries.
>
> That's pretty useful; two comments
>
>  - this could be useful for strings too so perhaps add it?

I can take a look at this too. Btw. I would like to add more such rules to 
allow at least something like if/else in the files. 

>  - MATCH_CONTAINS_NOT should be added as last element in match_type
>    to preserve binary compatibility with cache files

Are you sure that this change anything in already existing cache files? I 
didn't look deeper in the cachefile code, but if the rule is not used there 
should be IMO no change in the binary cache and if someone use the rule he 
have to regenerate the cache.

But I can move the line to the end of the list, but I tried to group the rules 
logical.

Danny


More information about the hal mailing list