[PATCH] add new fdi match attribute contains_not for strlist

David Zeuthen david at fubar.dk
Wed Feb 28 10:55:15 PST 2007


On Wed, 2007-02-28 at 19:41 +0100, Danny Kukawka wrote:
> >  - this could be useful for strings too so perhaps add it?
> 
> I can take a look at this too. Btw. I would like to add more such rules to 
> allow at least something like if/else in the files. 

Yeah, that sounds useful. 

Perhaps even add ways to run programs for investigating the device...
(should advise to use this very carefully, e.g. such a match statement
would be guarded by lots of enclosing <match> statements so it rarely
runs). Then again, that sounds like a callout but it's not really
(callouts are for enforcing policy when the device is fully
investigated). It would be like the probers we currently have. Shrug.

> >  - MATCH_CONTAINS_NOT should be added as last element in match_type
> >    to preserve binary compatibility with cache files
> 
> Are you sure that this change anything in already existing cache files? I 
> didn't look deeper in the cachefile code, but if the rule is not used there 
> should be IMO no change in the binary cache and if someone use the rule he 
> have to regenerate the cache.

Yeah, it's gonna break because the constants after the new entry will be
offset by 1.

     David




More information about the hal mailing list