[patches] Add dmi kernel class support into HAL

Richard Hughes hughsient at gmail.com
Tue Jun 5 08:15:09 PDT 2007


On Tue, 2007-06-05 at 11:05 -0400, David Zeuthen wrote:
> On Mon, 2007-06-04 at 18:55 +0100, Richard Hughes wrote:
> > On Mon, 2007-06-04 at 17:01 +0200, Lennart Poettering wrote:
> > > lspci and lsusb maintain ther databases outside of the kernel. And I
> > > think this case is not that different.
> > 
> > Patch attached. Please review.
> 
> How does this cope with some of the dmi sysfs files only being readable
> by uid 0? Or has that changed? 

It doesn't, I figured the hal-daemon would be run as root...

> Personally I think it's a bit silly if only uid 0 can read the UUID /
> serial number etc. - if you want to go down that road there's plenty of
> other things that needs fixing
> 
>  - USB serial numbers
>  - Disk serial numbers (look in /dev/disk/*)
>  - Firewire
>  - etc.

This is my view also. You could just pick the machine up and read the
code off the sticky label on the bottom.

> If you need to be uid 0 to get this, we need to collect the values of
> the sysfs file from a prober (running as uid 0) since the main hal
> daemon runs doesn't run as uid 0.

Ick. Ick. The prober is the very thing I'm trying to remove.

> (Also, I think it's spelled 'deprecated', not 'depricated' - or maybe
> the latter is a British thing :-)

Yes, I think you are correct.

Richard.




More information about the hal mailing list