[PATCH] Tablet PC support

[David Zeuthen]

On Thu, 2007-03-08 at 17:07 +0100, Danny Kukawka wrote:
> Hi,
> 
> here is a updated version of my Tablet PC patch for HAL. Due to changes
> in the kernel we don't need to call setserial for _all_ Tablet PC devices,
> but there are some which need special handling to get the running in the 
> correct way. This is the reason why thispatch also include a helper to 
> call setserial.
> 
> What this patch do:
>  * identify Wacom and Finepoint Tablet PC devices and port/irq 
>  * set system.formfactor.subtype to 'tabletpc' - this allow the desktop
>    to handle special tasks for Tablet PCs as e.g. show OnScreen Keyboard
>    in KDM/GDM
>  * added setserial helper to setup /dev/ttyS* devices with sepcial
>    parameter if needed
>  * add fdi-file to set needed parameter for special Tablet devices where 
>    the kernel can't setup the device correct and set callout to execute 
>    the helper for setserial 

So there's a few issues I have with this

 - It adds the capability input but there are no input device files to
   be found, no? Perhaps you should use another capability name?

 - hal-system-setserial is a too generic name - should be something
   that includes table since that's what it's used for

 - hal-system-setserial shouldn't use popt - we don't want such an extra
   dependency

 - Use system.hardware.product instead smbios.system.product etc.

 - Things like

    <match key="@info.parent:smbios.system.product" contains="HP Compaq tc4200">

   should go in hal-info

Thoughts?

     David