[PATCH] Tablet PC support

[Danny Kukawka]

On Montag, 12. März 2007, David Zeuthen wrote:
> So there's a few issues I have with this
> 
>  - It adds the capability input but there are no input device files to
>    be found, no? Perhaps you should use another capability name?

Hm, there is no special /dev/input/* device as IIRC for all serial input 
devices (as e.g. serial mouse). But this are input devices. I would not add
a special capability and namespace for this.

>  - hal-system-setserial is a too generic name - should be something
>    that includes table since that's what it's used for

Why? You can setup via this helper also any other serial device if you want.
There is no dependency to Tablets. (maybe I should replace the input.device.set
with pnp.device.set to be more generic here)

>  - hal-system-setserial shouldn't use popt - we don't want such an extra
>    dependency

I can remove the complete argument/popt stuff. This is maybe not needed.

>  - Use system.hardware.product instead smbios.system.product etc.

okay, this patch is quite old, I can switch to the new properties before 
commit.

>  - Things like
> 
>     <match key="@info.parent:smbios.system.product" contains="HP Compaq tc4200">

Not sure about this, because the callout depend on this. And IMO callouts related
settings/rules should be in the policy folder. Or not?

Danny