[PATCH] Tablet PC support

[David Zeuthen]

On Mon, 2007-03-12 at 20:53 +0100, Danny Kukawka wrote:
> On Montag, 12. März 2007, David Zeuthen wrote:
> > So there's a few issues I have with this
> > 
> >  - It adds the capability input but there are no input device files to
> >    be found, no? Perhaps you should use another capability name?
> 
> Hm, there is no special /dev/input/* device as IIRC for all serial input 
> devices (as e.g. serial mouse). But this are input devices. I would not add
> a special capability and namespace for this.

Well, it aint an input device until a kernel driver is bound :-). So I
think tagging it with something else is useful. Like, for example,
'tablet_input_device'.

> >  - hal-system-setserial is a too generic name - should be something
> >    that includes table since that's what it's used for
> 
> Why? You can setup via this helper also any other serial device if you want.
> There is no dependency to Tablets. (maybe I should replace the input.device.set
> with pnp.device.set to be more generic here)

That's fine; if it's truly generic it's fine.

> >  - hal-system-setserial shouldn't use popt - we don't want such an extra
> >    dependency
> 
> I can remove the complete argument/popt stuff. This is maybe not needed.

Just parse argv manually.

> >  - Use system.hardware.product instead smbios.system.product etc.
> 
> okay, this patch is quite old, I can switch to the new properties before 
> commit.

Cool.

> >  - Things like
> > 
> >     <match key="@info.parent:smbios.system.product" contains="HP Compaq tc4200">
> 
> Not sure about this, because the callout depend on this. And IMO callouts related
> settings/rules should be in the policy folder. Or not?

Just make sure it's done in a way such that the hal-info fdi file (in
'information') puts a tag on the device. Then your fdi file in hal (in
'policy') will pick up this tag and do the right thing. This works
because 'information' fdi files are processed before 'policy' fdi files.
We do the same thing for e.g. usbcsr wireless devices.

    David