[PATCH] fix configure for DELL stuff

David Zeuthen david at fubar.dk
Mon Mar 26 13:44:13 PDT 2007


On Mon, 2007-03-26 at 21:45 +0200, Danny Kukawka wrote:
> Hi,
> 
> this patch fixes configure for the DELL libsmbios stuff:
> 
> * build the Dell backlight addon also for x86_64. I see no reason why we 
> should build only for x86, libsmbios also build on x86_64 and the addon build 
> for me also on 64bit.

This is fine.

> * remove BUILD_DELL_RFKILL related stuff since this has no effect because it 
> get never uses. We don't build a own version of the dellWirelessCtl (If we do 
> this anytime, we can readd this to configure) in 0.5.9, hence there is no 
> need to do anything for this on configure. 

Hmm. OK. I had hoped we could write our own util so we'd only depend on
libsmbios and not external binaries. Anyway, for 0.5.9 let's just rely
on dellWirelessCtl - I've committed this patch to actually check that it
exist

 http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=49e7d0686b3fb49c6fbf2d9ccb1ab962f8cf702f

and this note

 http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=5052a31363655207771767fed4793566b774b585

to mention that it's optional and needs to live in /usr/bin.

     David




More information about the hal mailing list