[PATCH] fix configure for DELL stuff

Danny Kukawka danny.kukawka at web.de
Mon Mar 26 14:01:14 PDT 2007


On Montag, 26. März 2007, David Zeuthen wrote:
> On Mon, 2007-03-26 at 21:45 +0200, Danny Kukawka wrote:
> > Hi,
> >
> > this patch fixes configure for the DELL libsmbios stuff:
> >
> > * build the Dell backlight addon also for x86_64. I see no reason why we
> > should build only for x86, libsmbios also build on x86_64 and the addon
> > build for me also on 64bit.
>
> This is fine.
>
> > * remove BUILD_DELL_RFKILL related stuff since this has no effect because
> > it get never uses. We don't build a own version of the dellWirelessCtl
> > (If we do this anytime, we can readd this to configure) in 0.5.9, hence
> > there is no need to do anything for this on configure.
>
> Hmm. OK. I had hoped we could write our own util so we'd only depend on
> libsmbios and not external binaries. Anyway, for 0.5.9 let's just rely
> on dellWirelessCtl

I'm not complete against write somthing own, but this tool is already part of 
the libsmbios package and why should we write our own (atm) which also mean 
we have to monitor all changes in libsmbios and fix if needed? 

If this is really needed it's something for >= 0.5.10.

Commited the patch.

Danny


More information about the hal mailing list