[PATCH] update configure.in and use autoreconf

David Zeuthen david at fubar.dk
Wed May 2 20:18:54 PDT 2007


Hi,

Thanks for your feedback.

On Wed, 2007-05-02 at 08:00 +0200, Michael Biebl wrote:
> Please consider, that running autoreconf --force --install will
> overwrite the COPYING file.

Is there any way to avoid that?

> We also should raise the automake dependency to  1.8 or 1.9
> configure.in: AM_INIT_AUTOMAKE([gnu 1.9])
> It doesn't build with automake 1.5.

Done.

> I also noticed that the current logic in doc/man/Makefile.am is wrong:
> The *.in files should be added to EXTRA_DIST in any case, not
> depending on MAN_PAGES_ENABLED or HAVE_POLKIT.

Fixed.

> We also shouldn't distribute man_MANS in EXTRA_DIST, because these
> files are autobuilt.
> It is inconsistent to remove them on clean and at the same time adding
> them to EXTRA_DIST.

Does this patch make it better?

http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=627a4c08677b5a9c703d51d694c945110ce1d8cf

     David




More information about the hal mailing list