[PATCH] update configure.in and use autoreconf

Michael Biebl mbiebl at gmail.com
Wed May 2 23:01:02 PDT 2007


2007/5/3, David Zeuthen <david at fubar.dk>:
>
> On Wed, 2007-05-02 at 08:00 +0200, Michael Biebl wrote:
> > Please consider, that running autoreconf --force --install will
> > overwrite the COPYING file.
>
> Is there any way to avoid that?

You could remove the "--force" parameter. But this has the unpleasant
side effect that libtoolize won't update config.{guess,sub} and
ltmain.sh.

>
> > I also noticed that the current logic in doc/man/Makefile.am is wrong:
> > The *.in files should be added to EXTRA_DIST in any case, not
> > depending on MAN_PAGES_ENABLED or HAVE_POLKIT.
>
> Fixed.
>
> > We also shouldn't distribute man_MANS in EXTRA_DIST, because these
> > files are autobuilt.
> > It is inconsistent to remove them on clean and at the same time adding
> > them to EXTRA_DIST.
>
> Does this patch make it better?
>
> http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=627a4c08677b5a9c703d51d694c945110ce1d8cf
>

Installing the  hal-is-caller-privileged.1 manpage conditionally was
not a bad idea, imo.
You could use the attached patch to achieve that again (even if it
makes the Makefile.am a bit more inconsistent, as you have to
specificy hal-is-caller-privileged at two places)

Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: doc.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20070503/13318083/doc.bin


More information about the hal mailing list