Patch: remove incorrect vbestate_restore quirk for some laptops

Frederic Crozat fcrozat at mandriva.com
Thu May 3 05:00:37 PDT 2007


Le jeudi 03 mai 2007 à 12:28 +0200, Danny Kukawka a écrit :
> On Donnerstag, 3. Mai 2007, Frederic Crozat wrote:
> > Le jeudi 03 mai 2007 à 11:25 +0200, Frederic Crozat a écrit :
> > > Le mercredi 02 mai 2007 à 20:51 +0200, Danny Kukawka a écrit :
> [...]
> > > > You miss something in the testplan: suspend to ram has also to work
> > > > from console. And for your changes (remove vbestate_restore quirk) this
> > > > wouldn't work in the most cases! So I would vote against this changes
> > > > until this get rechecked with init=/bin/bash (start with
> > > > init=/bin/bash, call suspendToRam, resume and check if all work)
> > >
> > > I don't recall seeing such regressions for console suspend but I'll try
> > > to grab one of those problematic laptops.
> >
> > I just tested one of the laptops. And you were right, restoring for
> > framebuffer is broken if vbestate_restore is not used.
> 
> Which one was it?

HP nc4200

I didn't test the other ones on the list.

I've also tested with s2ram just now and the same issue is present.

However, after looking at s2ram whitelist recent changes (btw, it would
be nice to push all modifications and new additions to hal-info), I
tried to replace vbestate_restore with vbemode_restore and both X and
console suspend are working fine now.

David, could you put this patch on hold until I retest the various
laptops listed in my patch ?

I'll send a new patch shortly.

-- 
Frederic Crozat <fcrozat at mandriva.com>
Mandriva



More information about the hal mailing list