[PATCH] HAL runner doesn't handle D-Bus disconnect properly

David Zeuthen david at fubar.dk
Wed May 23 10:30:00 PDT 2007


Hi,

Sorry for the lag; been traveling,

On Fri, 2007-05-11 at 15:17 +0200, Frederic Crozat wrote:
> Le mercredi 25 avril 2007 à 16:07 -0400, Doug Goldstein a écrit :
> > It appears that if the connection to D-Bus is lost or some such is lost,
> > HAL doesn't check the result of DBusPendingCall from
> > dbus_connection_send_with_reply() [1] to see if the result is not NULL
> > and as such an invalid case is being hit within the D-Bus API and we're
> > hitting a D-Bus assert and causing a crash.
> > 
> > Provided is a patch to see if it's NULL and handle it properly.
> 
> it seems this patch was forgotten somehow. 
> 
> David, could you review it ?

Yeah, I must have overlooked that one. Committed to HEAD and 0.5.9.
Thanks Doug and Frederic!

    David




More information about the hal mailing list