[PATCH] export NumLock/CapsLock/ScrollLock event through addon-input.c

[itrs lin]

Dear Sir,

The code does same thing as existing code and why this is a layer violation
and existing one is not ?
It just get LED status change instead of setting it and this make OSD design
clean and clear without polling LED status and make unnecessary Xlib
dependency .

BR,
Sam


2007/11/28, Daniel Stone <daniel.stone at nokia.com>:
>
> On Wed, Nov 28, 2007 at 03:47:46AM +0800, ext Sam Lin wrote:
> > For tablet/UMPC there is a requirement to make NumLock/CapsLock status
> > visible on systray or on OSD and
> > that make condition signal of such status change from addon-input.chelpful.
>
> Please don't do this.  All your interaction with keyboards is through X,
> so why cause a layering violation? Just ask X for the LED status.
>
> Cheers,
> Daniel
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFHTKMk68xJuWtYYdURAsuoAJ9rnRId7RaHFJ8Z+zZMSdB1fLUjwgCfaZVF
> iZKisTX86aHBzQCqUcnv8hc=
> =U/Oi
> -----END PGP SIGNATURE-----
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/hal/attachments/20071129/1a4ee1ce/attachment.htm