[PATCH ]Re: Blu-ray support

[Danny Kukawka]

On Mittwoch, 10. Oktober 2007, Bastien Nocera wrote:
> Heya,
>
> I posted an untested patch, with the values taken from the latest dvd
> +rw-tools version:
> http://bugs.freedesktop.org/show_bug.cgi?id=12767
>
> I'd appreciate comments, and actual testing. Note that the spec isn't
> updated, and that the Blu-ray video disc detection probably doesn't
> work, as they're usually UDF, not ISO9660.

Some comments:
* the patch didn't compile ('}' missing in probe-volume.c:264)
* I would prevent mix LIBHAL_STORAGE_ICON_DISC_* with
  DRIVE_CDROM_CAPS_* in probe-storage.c
* in get_disc_capacity_dvdr_from_type() im miss code for 0x42 (BR-R RRM) not    
  sure if they should get handled like 0x41 (BD-R SRM)

I have added a new version of the patch with this stuff fixed and also add 
some more support for HD DVD* discs (didn't add code to 
get_disc_capacity_dvdr_from_type() atm).

Danny

 linux/probing/linux_dvd_rw_utils.c |   36 +++++++++++++++++++++++++++
 linux/probing/linux_dvd_rw_utils.h |    7 +++++
 linux/probing/probe-storage.c      |   12 +++++++++
 linux/probing/probe-volume.c       |    7 +++++
 solaris/probing/probe-volume.c     |    2 -
 5 files changed, 62 insertions(+), 2 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-BluRay_HDDVD-support_v1.patch
Type: text/x-diff
Size: 5652 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20071010/bab8a22c/attachment.patch