[PATCH ]Re: Blu-ray support

[Bastien Nocera]

On Wed, 2007-10-10 at 16:35 +0200, Danny Kukawka wrote:
> On Mittwoch, 10. Oktober 2007, Bastien Nocera wrote:
> > Heya,
> >
> > I posted an untested patch, with the values taken from the latest dvd
> > +rw-tools version:
> > http://bugs.freedesktop.org/show_bug.cgi?id=12767
> >
> > I'd appreciate comments, and actual testing. Note that the spec isn't
> > updated, and that the Blu-ray video disc detection probably doesn't
> > work, as they're usually UDF, not ISO9660.
> 
> Some comments:
> * the patch didn't compile ('}' missing in probe-volume.c:264)

Told you it was untested :)

> * I would prevent mix LIBHAL_STORAGE_ICON_DISC_* with
>   DRIVE_CDROM_CAPS_* in probe-storage.c

Thinko, good catch.

> * in get_disc_capacity_dvdr_from_type() im miss code for 0x42 (BR-R RRM) not    
>   sure if they should get handled like 0x41 (BD-R SRM)

0x42 isn't supported by dvd+rw-tools, so I don't know if the capacity
calculation works in the same way. Maybe adding a comment to that effect
would be useful.

> I have added a new version of the patch with this stuff fixed and also add 
> some more support for HD DVD* discs (didn't add code to 
> get_disc_capacity_dvdr_from_type() atm).

Looks good.

-- 
Bastien Nocera <hadess at hadess.net>