Improving the suspend quirks guessworking

Danny Kukawka danny.kukawka at web.de
Wed Mar 26 06:30:42 PDT 2008


On Mittwoch, 26. März 2008, Martin Pitt wrote:
> Danny Kukawka [2008-03-25 21:07 +0100]:
> > Because only one person need to get in touch with us and all other can
> > benefit from this report. I don't see any problem here. Such a default
> > would let the machine work with one driver or kernel version and it would
> > break maybe with the next, where is there the benefit?
>
> The very same is true for the 'upstream' quirks, since a set of quirks
> which works for one person might break another person's box who uses a
> different graphics driver or kernel version. (I. e. if someone using
> nv reports quirks, you'll break it for someone using the nvidia
> driver; which is exactly what my patch fixes.)

I don't see how the patches would fix the case you describe above. If the 
machine is listed from a user with nv (without any driver matches) your 
quirk-patch wouldn't fix anything for the user that use nvida. The existing 
patch would still be used for both users and would break one of them.

Danny




More information about the hal mailing list