Changing hal-info to have X friendly key symbols

[Martin Pitt]

Hello,

thanks for review.

Matthew Garrett [2009-02-04 15:29 +0000]:
> What are the expected semantics of the "setup" key? "help" sounds like a 
> better choice.

Indeed, fixed.

> 
> +          <append key="input.keymap.data" type="strlist">6b:previoussong</append> <!-- Thottle Down -->
> +          <append key="input.keymap.data" type="strlist">6d:nextsong</append> <!-- Thottle Up -->
> 
> Really doesn't sound right (not that the existing mappings are any 
> better)

I agree, but I don't have the slightest idea what "throttle" should do
on a keyboard. It was channelup/down before, so previous/nextsong are
closest to the originally configured meaning.

If this is objectionable, let's just revert that hunk completely.

> -          <append key="input.keymap.data" type="strlist">0x08a:tv</append>
> +          <append key="input.keymap.data" type="strlist">0x08a:media</append> <!-- high keycode: "radio" -->
> 
> What's the glyph on this key?

I fixed the comment to say "tv" (which was the original code). Nobody
here has an Acer with that key, though.

> 
> -        <append key="input.keymap.data" type="strlist">0x17:vendor</append> <!-- ThinkPad/ThinkVantage button -->
> +        <append key="input.keymap.data" type="strlist">0x17:computer</append> <!-- ThinkPad/ThinkVantage button  (high keycode: "vendor") -->
> 
> My recollection is that KEY_COMPUTER maps to the key that would open "My 
> computer" on Windows systems. I'm not sure it makes sense to map the 
> Thinkvantage key to the same thing.

Indeed, Steve Langasek already brought that up. To be consistent to
e. g. the "Lenovo Care" button, I now changed it to prog1.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-convert-keymaps-to-use-X11-friendly-symbols.patch
Type: text/x-diff
Size: 10248 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20090204/4f4e58d5/attachment.patch