use util-linux-ng's libblkid instead of libvolume_id

[Kay Sievers]

On Thu, 2009-03-26 at 22:31 +0100, Karel Zak wrote:
> Good work, the patch looks good.

Thanks!

> On Thu, Mar 26, 2009 at 05:10:57PM +0100, Kay Sievers wrote:
> > +blkid_module="blkid >= 1.99"
> 
>  I'm not sure if this is really the final blkid version number for
>  util-linux-v2.15. I need to talk about it with Ted -- unfortunately
>  he is probably too busy now... (The current version in e2fsprogs is 1.41
>  and I hope this version will be freezed -- in such case we can use
>  something better than 1.99 -- for example 1.43 or so.)

Changed to >= 1.43, which should be safe.

> > +#include <blkid/blkid.h>
> 
>  This is correct, but I'd suggest to use <blkid.h> and proper "-I" gcc
>  option (pkg-config blkid --cflags).

Yeah, works. BLKID_CFLAGS seems to contain that.

> > +				if (blkid_probe_lookup_value (pr, "USAGE", &usage, &len) == 0 &&
> 
>  the "len" is optional, you can use NULL.

Removed.

> > +			blkid_probe_set_device (pr, fd, vol_probe_offset, vol_size);
> 
>  Please, test return code. This function reads 512 bytes from the
>  device and the read() can fail.

Done.
 
>  Note that you needn't to set volume size, that's optional, the
>  library can internally ask for BLKGETSIZE64.

Good to know. But we have the value anyway to export it.

Thanks,
Kay
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-blkid2.patch
Type: text/x-patch
Size: 12551 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20090326/0ef75486/attachment.bin