[HarfBuzz] harfbuzz-ng: Branch 'master' - 5 commits

Jonathan Kew jonathan at jfkew.plus.com
Thu Apr 29 16:40:27 PDT 2010


On 29 Apr 2010, at 19:32, Behdad Esfahbod wrote:

> +#if __GNUC__ >= 3
> +#define HB_FUNC __PRETTY_FUNCTION__
> +#elif defined(_MSC_VER)
> +#define HB_FUNC __FUNCSIG__
> +#else
> +#define HB_FUNC __func__
> +#endif

Doesn't this need to test whether __GNUC__ is defined, before comparing its value? E.g.

 #if defined(__GNUC__) && (__GNUC__ >= 3)

JK




More information about the HarfBuzz mailing list